PCP-2739: Support watchNamespace allowing controller to watch objects in the specified namespace #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We were seeing multiple CP nodes getting launched for a single node Microk8s MAAS cluster. This was happening because of the unavailability of watchNamespace in the control-plane-microk8s controller. Because of Palette's deployment where we have one controller pod per namespace, multiple reconcilers from different namespaces across a PCG were watching the objects across namespaces and creating machines.
Fix: We added the support for watchNamespace in the control-plane-microk8s controller which will restrict the controller to watch cluster-api objects in its namespace only when specified.